[generate-dump] Remove Arista specific logic #1482
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Samuel Angebault <staphylo@arista.com>
|
This change is fully ready for |
jleveque
approved these changes
Mar 5, 2021
|
Retest this please |
|
retest this please |
daall
pushed a commit
that referenced
this pull request
Mar 12, 2021
Cleanup review to remove Arista specific logic from generate_dump. We now implement the vendor specific hw-management-generate-dump.sh hook which achieves the same purpose. Signed-off-by: Samuel Angebault <staphylo@arista.com>
stepanblyschak
pushed a commit
to stepanblyschak/sonic-utilities
that referenced
this pull request
Apr 28, 2022
d03c6ccc90b92d9319c500a8adcf727a9fa5609b (HEAD -> 201911, origin/201911) [intfsorch] Init proxy_arp variable while adding router interface. (sonic-net#1473) 9e7c0bc8e3f2c7c5422f2f8a2c6498f659dcdf84 [drop counters] Clarify log messages for initial counter setup (sonic-net#1445) da8ac754fa1c36f9bb7ba1210017f915f339cfe0 Create vnet tunnel map only if it doesn't exist (sonic-net#1482) Signed-off-by: Abhishek Dosi <abdosi@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Cleanup review to remove Arista specific logic from
generate_dump.We now implement the vendor specific
hw-management-generate-dump.shhook which achieves the same purpose.How I did it
Our platform drivers install the hook under
/usr/bin/hw-management-generate-dump.shHow to verify it
Run
generate_dumpand validate that thehw-mgmt-dumpfile in the dump gets populated and has content.